linux-kernel - Re: [PATCH 209/606] Input: atmel_captouch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2022 11:49:29 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-input@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 209/606] Input: atmel_captouch - Convert to i2c's
 .probe_new()

On Fri, 18 Nov 2022 23:39:03 +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/input/misc/atmel_captouch.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/misc/atmel_captouch.c b/drivers/input/misc/atmel_captouch.c
> index 156c699a8913..d9704b174d3a 100644
> --- a/drivers/input/misc/atmel_captouch.c
> +++ b/drivers/input/misc/atmel_captouch.c
> @@ -161,8 +161,7 @@ static irqreturn_t atmel_captouch_isr(int irq, void *data)
>  /*
>   * Probe function to setup the device, input system and interrupt
>   */
> -static int atmel_captouch_probe(struct i2c_client *client,
> -		const struct i2c_device_id *id)
> +static int atmel_captouch_probe(struct i2c_client *client)
>  {
>  	struct atmel_captouch_device *capdev;
>  	struct device *dev = &client->dev;
> @@ -264,7 +263,7 @@ static const struct i2c_device_id atmel_captouch_id[] = {
>  MODULE_DEVICE_TABLE(i2c, atmel_captouch_id);
>  
>  static struct i2c_driver atmel_captouch_driver = {
> -	.probe		= atmel_captouch_probe,
> +	.probe_new	= atmel_captouch_probe,
>  	.id_table	= atmel_captouch_id,
>  	.driver		= {
>  		.name	= "atmel_captouch",

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support