linux-kernel - Re: [PATCH 222/606] Input: synaptics_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221206114952.0323433d@endymion.delvare>
Date:   Tue, 6 Dec 2022 11:49:52 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Peter Senna Tschudin <peter.senna@...il.com>,
        Krzysztof Hałasa <khalasa@...p.pl>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 222/606] Input: synaptics_i2c - Convert to i2c's
 .probe_new()

On Fri, 18 Nov 2022 23:39:16 +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/input/mouse/synaptics_i2c.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c
> index 987ee67a1045..6487c8c60d5e 100644
> --- a/drivers/input/mouse/synaptics_i2c.c
> +++ b/drivers/input/mouse/synaptics_i2c.c
> @@ -521,8 +521,7 @@ static struct synaptics_i2c *synaptics_i2c_touch_create(struct i2c_client *clien
>  	return touch;
>  }
>  
> -static int synaptics_i2c_probe(struct i2c_client *client,
> -			       const struct i2c_device_id *dev_id)
> +static int synaptics_i2c_probe(struct i2c_client *client)
>  {
>  	int ret;
>  	struct synaptics_i2c *touch;
> @@ -651,7 +650,7 @@ static struct i2c_driver synaptics_i2c_driver = {
>  		.pm	= &synaptics_i2c_pm,
>  	},
>  
> -	.probe		= synaptics_i2c_probe,
> +	.probe_new	= synaptics_i2c_probe,
>  	.remove		= synaptics_i2c_remove,
>  
>  	.id_table	= synaptics_i2c_id_table,

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support