linux-kernel - Re: [PATCH 431/606] mfd: khadas-mcu: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2022 11:59:08 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Lee Jones <lee@...nel.org>
Cc:     Neil Armstrong <neil.armstrong@...aro.org>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        linux-kernel@...r.kernel.org, Wolfram Sang <wsa@...nel.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Grant Likely <grant.likely@...aro.org>,
        linux-amlogic@...ts.infradead.org, Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 431/606] mfd: khadas-mcu: Convert to i2c's .probe_new()

Hey Lee,

On Mon, Nov 21, 2022 at 04:51:21PM +0000, Lee Jones wrote:
> On Mon, 21 Nov 2022, Uwe Kleine-König wrote:
> 
> > Hello Lee,
> > 
> > On Mon, Nov 21, 2022 at 12:32:10PM +0000, Lee Jones wrote:
> > > On Fri, 18 Nov 2022, Uwe Kleine-König wrote:
> > > 
> > > > From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > > > 
> > > > The probe function doesn't make use of the i2c_device_id * parameter so it
> > > > can be trivially converted.
> > > > 
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > > > ---
> > > >  drivers/mfd/khadas-mcu.c | 5 ++---
> > > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > > 
> > > After a week or so, please collect-up all the tags you have received
> > > and submit a per-subsystem set for me to hoover up, thanks.
> > 
> > For mfd I'd do:
> > 
> > 	git checkout mfd/for-next
> > 	b4 am -P 413-481 20221118224540.619276-1-uwe@...ine-koenig.org
> > 	git am ./20221118_uwe_i2c_complete_conversion_to_i2c_probe_new.mbx
> > 	git send-email --to .... --cc .... mfd/for-next
> 
> That's just crazy enough to work.
> 
> Thanks for the tip.

On irc you said you'd care for application of these patches ("I plan to
attempt the b4 solution"), they didn't land in next yet. Do you need a
reminder? Something else?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)