linux-kernel - Re: [PATCH v3 3/4] include/asm-generic/io.h: remove performing pointer arithmetic on a null pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <43fda82a-f3df-42c8-9eb2-23cf2dce8628@app.fastmail.com>
Date:   Tue, 06 Dec 2022 15:22:58 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Song Chen" <chensong_2000@....cn>,
        "Steven Rostedt" <rostedt@...dmis.org>,
        "Masami Hiramatsu" <mhiramat@...nel.org>,
        "Niklas Schnelle" <schnelle@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH v3 3/4] include/asm-generic/io.h: remove performing pointer
 arithmetic on a null pointer

On Tue, Dec 6, 2022, at 07:01, Song Chen wrote:
> 在 2022/12/5 18:04, Arnd Bergmann 写道:
>> On Mon, Dec 5, 2022, at 09:30, Song Chen wrote:
>> 
>> We have discussed this bit multiple times, and Niklas Schnelle
>> last posted his series to fix this as an RFC in [1].
>> 
>
> Trace triggers the warning accidentally by including io.h indirectly 
> because of the absence of PCI_IOBASE in hexagon. So what trace can do in 
> this case is either to suppress warning or just ignore it, the warning 
> will go away as long as hexagon has put PCI_IOBASE in place or 
> implemented its own inb() etc, i think they will do it sooner or later.

hexagon/riscv/s390 should not implement inb(), there is no reason
for that because no hardware uses it. Half of the other architectures
that currently implement inb() should not do so either.

> Introducing HAS_IOPORT to trace seems no necessary and too much impact.

I don't think that trace has anything to do with it, the asm-generic
header should just not provde the inb() interface on architectures
that don't use it.

    Arnd