linux-kernel - Re: [PATCH 0/6] Make remove() of any bus based driver void returned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYCP286MB2323467DEE64E8CE2F8DD212CA1B9@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
Date:   Tue, 6 Dec 2022 22:33:56 +0800
From:   Dawei Li <set_pte_at@...look.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     johannes@...solutions.net, robert.jarzmik@...e.fr, jgross@...e.com,
        sstabellini@...nel.org, oleksandr_tyshchenko@...m.com,
        roger.pau@...rix.com, srinivas.kandagatla@...aro.org,
        bgoswami@...cinc.com, mpe@...erman.id.au, npiggin@...il.com,
        christophe.leroy@...roup.eu, kys@...rosoft.com,
        haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
        alsa-devel@...a-project.org, linuxppc-dev@...ts.ozlabs.org,
        xen-devel@...ts.xenproject.org, linux-hyperv@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] Make remove() of any bus based driver void returned

On Mon, Dec 05, 2022 at 05:00:52PM +0100, Greg KH wrote:
> On Mon, Dec 05, 2022 at 11:36:38PM +0800, Dawei Li wrote:
> > For bus-based driver, device removal is implemented as:
> > device_remove() => bus->remove() => driver->remove()
> > 
> > Driver core needs no feedback from bus driver about the result of
> > remove callback. In which case, commit fc7a6209d571 ("bus: Make
> > remove callback return void") forces bus_type::remove be void-returned.
> > 
> > Now we have the situation that both 1st & 2nd part of calling chain
> > are void returned, so it does not make much sense for the last one
> > (driver->remove) to return non-void to its caller.
> > 
> > So the basic idea behind this patchset is making remove() callback of
> > any bus-based driver to be void returned.
> > 
> > This patchset includes changes for drivers below:
> > 1. hyperv
> > 2. macio
> > 3. apr
> > 4. xen
> > 5. ac87
> > 6. soundbus

Hi Greg:
Thanks for the reviewing.
> 
> Then that should be 6 different patchsets going to 6 different
> subsystems.  No need to make this seems like a unified set of patches at
> all.
Right, will fix all the issues for this patchset and resend them in 6
independent patches.

Thanks
      Dawei

> 
> > Q: Why not platform drivers?
> > A: Too many of them.(maybe 4K+)
> 
> That will have to be done eventually, right?
> 
> thanks,
> 
> greg k-h