linux-kernel - Re: [PATCH] i2c: mux: Convert to use sysfs_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <029fd171-18c6-7588-453b-ed8c4f12ab38@axentia.se>
Date:   Tue, 6 Dec 2022 15:34:10 +0100
From:   Peter Rosin <peda@...ntia.se>
To:     ye.xingchen@....com.cn, wsa+renesas@...g-engineering.com
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: mux: Convert to use sysfs_emit_at() API

Hi!

2022-12-06 at 12:36, ye.xingchen@....com.cn wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>  drivers/i2c/muxes/i2c-demux-pinctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c
> index f7a7405d4350..6dc23aedcaed 100644
> --- a/drivers/i2c/muxes/i2c-demux-pinctrl.c
> +++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c
> @@ -167,7 +167,7 @@ static ssize_t available_masters_show(struct device *dev,
>  	int count = 0, i;
> 
>  	for (i = 0; i < priv->num_chan && count < PAGE_SIZE; i++)
> -		count += scnprintf(buf + count, PAGE_SIZE - count, "%d:%pOF%c",
> +		count += sysfs_emit_at(buf, count, "%d:%pOF%c",
>  				   i, priv->chan[i].parent_np,
>  				   i == priv->num_chan - 1 ? '\n' : ' ');
> 

You need to adjust the indentation of the two follow-up lines.

Cheers,
Peter