linux-kernel - Re: [PATCH 2/3] perf build: Use libtraceevent from the system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y49skYa5VYPMU+RF@kernel.org>
Date:   Tue, 6 Dec 2022 13:23:45 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        bpf@...r.kernel.org, Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 2/3] perf build: Use libtraceevent from the system

Em Tue, Dec 06, 2022 at 01:20:12PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Dec 06, 2022 at 01:15:04PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Dec 05, 2022 at 02:59:39PM -0800, Ian Rogers escreveu:
> > > Remove the LIBTRACEEVENT_DYNAMIC and LIBTRACEFS_DYNAMIC. If
> > > libtraceevent isn't installed or NO_LIBTRACEEVENT=1 is passed to the
> > > build, don't compile in libtraceevent and libtracefs support. This
> > > also disables CONFIG_TRACE that controls "perf
> > > trace". CONFIG_TRACEEVENT is used to control enablement in
> > > Build/Makefiles, HAVE_LIBTRACEEVENT is used in C code. Without
> > > HAVE_LIBTRACEEVENT tracepoints are disabled and as such the commands
> > > kmem, kwork, lock, sched and timechart are removed. The majority of
> > > commands continue to work including "perf test".
> > 
> > Had just this .rej and I fixed it up manually, testing now:
> 
> Investigating:
> 
> [acme@...co perf]$ rpm -q libtraceevent-devel
> libtraceevent-devel-1.5.3-2.fc36.x86_64
> [acme@...co perf]$
> [acme@...co perf]$ grep -i traceevent /tmp/build/perf/FEATURE-DUMP
> feature-libtraceevent=1
> [acme@...co perf]$
> 
> [acme@...co perf]$ alias m
> alias m='rm -rf ~/libexec/perf-core/ ; perf stat -e cycles:u,instructions:u make -k BUILD_BPF_SKEL=1 O=/tmp/build/perf -C tools/perf install-bin && perf test python'
> [acme@...co perf]$
> 
> [acme@...co perf]$ rpm -ql libtraceevent-devel | grep \.h$ | xargs grep tep_print_flag_sym
> /usr/include/traceevent/event-parse.h:struct tep_print_flag_sym {
> /usr/include/traceevent/event-parse.h:	struct tep_print_flag_sym	*next;
> /usr/include/traceevent/event-parse.h:	struct tep_print_flag_sym	*flags;
> /usr/include/traceevent/event-parse.h:	struct tep_print_flag_sym	*symbols;
> [acme@...co perf]$
> 
> util/scripting-engines/trace-event-perl.c:104:43: error: ‘struct tep_print_flag_sym’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>   104 | static void define_symbolic_values(struct tep_print_flag_sym *field,
>       |                                           ^~~~~~~~~~~~~~~~~~
> util/scripting-engines/trace-event-perl.c: In function ‘define_symbolic_values’:

This cured it, folding into your patch:

diff --git a/tools/perf/util/scripting-engines/trace-event-perl.c b/tools/perf/util/scripting-engines/trace-event-perl.c
index 5b602b6d46854133..0bacb49408f84adf 100644
--- a/tools/perf/util/scripting-engines/trace-event-perl.c
+++ b/tools/perf/util/scripting-engines/trace-event-perl.c
@@ -27,6 +27,7 @@
 #include <errno.h>
 #include <linux/bitmap.h>
 #include <linux/time64.h>
+#include <traceevent/event-parse.h>
 
 #include <stdbool.h>
 /* perl needs the following define, right after including stdbool.h */