[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <202212070913161959936@zte.com.cn>
Date: Wed, 7 Dec 2022 09:13:16 +0800 (CST)
From: <yang.yang29@....com.cn>
To: <airlied@...hat.com>
Cc: <kraxel@...hat.com>, <gurchetansingh@...omium.org>,
<olvaffe@...il.com>, <daniel@...ll.ch>,
<dri-devel@...ts.freedesktop.org>,
<virtualization@...ts.linux-foundation.org>,
<linux-kernel@...r.kernel.org>, <xu.panda@....com.cn>,
<yang.yang29@....com.cn>
Subject: [PATCH linux-next] drm/virtio: use strscpy() to instead of strncpy()
From: Xu Panda <xu.panda@....com.cn>
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.
Signed-off-by: Xu Panda <xu.panda@....com.cn>
Signed-off-by: Yang Yang <yang.yang29@....com>
---
drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
index 9ff8660b50ad..7d95bc74b307 100644
--- a/drivers/gpu/drm/virtio/virtgpu_vq.c
+++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
@@ -916,8 +916,7 @@ void virtio_gpu_cmd_context_create(struct virtio_gpu_device *vgdev, uint32_t id,
cmd_p->hdr.ctx_id = cpu_to_le32(id);
cmd_p->nlen = cpu_to_le32(nlen);
cmd_p->context_init = cpu_to_le32(context_init);
- strncpy(cmd_p->debug_name, name, sizeof(cmd_p->debug_name) - 1);
- cmd_p->debug_name[sizeof(cmd_p->debug_name) - 1] = 0;
+ strscpy(cmd_p->debug_name, name, sizeof(cmd_p->debug_name));
virtio_gpu_queue_ctrl_buffer(vgdev, vbuf);
}
--
2.15.2
Powered by blists - more mailing lists