linux-kernel - Re: [PATCH linux-next] drm/virtio: use strscpy() to instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <257f88ec-6bfc-0e91-610a-41a1af8e1180@collabora.com>
Date:   Mon, 27 Feb 2023 03:04:29 +0300
From:   Dmitry Osipenko <dmitry.osipenko@...labora.com>
To:     yang.yang29@....com.cn, airlied@...hat.com
Cc:     xu.panda@....com.cn, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org, kraxel@...hat.com,
        gurchetansingh@...omium.org
Subject: Re: [PATCH linux-next] drm/virtio: use strscpy() to instead of
 strncpy()

On 12/7/22 04:13, yang.yang29@....com.cn wrote:
> From: Xu Panda <xu.panda@....com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
> 
> Signed-off-by: Xu Panda <xu.panda@....com.cn>
> Signed-off-by: Yang Yang <yang.yang29@....com>
> ---
>  drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
> index 9ff8660b50ad..7d95bc74b307 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
> @@ -916,8 +916,7 @@ void virtio_gpu_cmd_context_create(struct virtio_gpu_device *vgdev, uint32_t id,
>  	cmd_p->hdr.ctx_id = cpu_to_le32(id);
>  	cmd_p->nlen = cpu_to_le32(nlen);
>  	cmd_p->context_init = cpu_to_le32(context_init);
> -	strncpy(cmd_p->debug_name, name, sizeof(cmd_p->debug_name) - 1);
> -	cmd_p->debug_name[sizeof(cmd_p->debug_name) - 1] = 0;
> +	strscpy(cmd_p->debug_name, name, sizeof(cmd_p->debug_name));
>  	virtio_gpu_queue_ctrl_buffer(vgdev, vbuf);
>  }
> 

Applied to misc-next

-- 
Best regards,
Dmitry