linux-kernel - Re: [PATCH 0/1] HID: uclogic: Add HID_QUIRK_HIDINPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5B0gwGZJ/PQyV4+@fedora>
Date:   Wed, 7 Dec 2022 12:09:55 +0100
From:   José Expósito <jose.exposito89@...il.com>
To:     Alexander Zhang <alex@...xyzhang.dev>
Cc:     Jiri Kosina <jikos@...nel.org>, benjamin.tissoires@...hat.com,
        openglfreak@...glemail.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/1] HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

Hi Alexander,

On Mon, Dec 05, 2022 at 04:49:10PM -0800, Alexander Zhang wrote:
> Hello,
> 
> On 11/19/22 11:01 PM, Alexander Zhang wrote:
> > On 11/14/22 6:10 AM, Jiri Kosina wrote:
> > > On Thu, 10 Nov 2022, Alexander Zhang wrote:
> > > 
> > > > Hi José,
> > > > 
> > > > On 11/10/22 9:40 AM, José Expósito wrote:
> > > > > Hi everyone,
> > > > > 
> > > > > About 3 months ago, Torge Matthies sent a patch fixing an issue with
> > > > > his XP-Pen Star G640 [1].
> > > > > 
> > > > > His patch changes the IS_INPUT_APPLICATION() macro to accept
> > > > > HID_DG_DIGITIZER. However, it looks like it is not being merged because
> > > > > of the possible side effects that changing that macro could generate.
> > > > > 
> > > > > This patch aims to fix the same issue but using a more conservative
> > > > > approach hoping that the bug can be fixed.
> > > > > 
> > > > > Torge, Alexander, could you test it and confirm that it fixes your
> > > > > issues, please?
> > > > 
> > > > I tested the patch on commit 4bbf3422df78 and it fixes the issue.
> > > 
> > > I will add
> > > 
> > >     Tested-by: Alexander Zhang <alex@...xyzhang.dev>
> > > 
> > > to the commit; please speak up if you disagree.
> > 
> > I'm not sure if you're still waiting for a response from me but I'm fine
> > with that.
> 
> Is there something preventing this patch from being merged? I'm not very
> familiar with the kernel development process.

The patch is already applied in the for-next branch, you can find it here:
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-next&id=3405a4beaaa8

Jose

> Best,
> Alexander Zhang