[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdbjaiDhPcVH115w25oxseWrz=Yb-ugkmCOiqhRDmDZj5A@mail.gmail.com>
Date: Thu, 8 Dec 2022 22:15:07 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: William Qiu <william.qiu@...rfivetech.com>
Cc: linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
linux-mmc@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Jaehoon Chung <jh80.chung@...sung.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/3] riscv: dts: starfive: Add mmc node
Hi William,
thanks for your patch!
On Wed, Dec 7, 2022 at 2:17 PM William Qiu <william.qiu@...rfivetech.com> wrote:
> + starfive,sys-syscon = <&sys_syscon 0x14 0x1a 0x7c000000>;
(...)
> + starfive,sys-syscon = <&sys_syscon 0x9c 0x1 0x3e>;
These are registster offsets and shifts. Don't define such stuff in your device
tree, use #defines in the code and just provide the phandle.
Yours,
Linus Walleij
Powered by blists - more mailing lists