[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b56b3363-5792-cf51-0ffe-914afccaa423@starfivetech.com>
Date: Fri, 9 Dec 2022 19:18:21 +0800
From: William Qiu <william.qiu@...rfivetech.com>
To: Linus Walleij <linus.walleij@...aro.org>
CC: <linux-riscv@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-mmc@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
Jaehoon Chung <jh80.chung@...sung.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Add bindings for StarFive
On 2022/12/9 5:13, Linus Walleij wrote:
> Hi William,
>
> thanks for your patch!
>
> On Wed, Dec 7, 2022 at 2:17 PM William Qiu <william.qiu@...rfivetech.com> wrote:
>
>> Add documentation to describe StarFive
>> designware mobile storage host controller driver.
>>
>> Signed-off-by: William Qiu <william.qiu@...rfivetech.com>
>
> (...)
>
>> + starfive,sys-syscon:
>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>> + description:
>> + The desired number of times that the host execute tuning when needed.
>
> This is not consistent with the use in the code of the attached driver.
> There it is a phandle, and it has three cells, which I am critical of.
> Also this description is hard to understand.
>
Will update all of it in next version.
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - clock-names
>> + - interrupts
>
> I don't think the syscon phandle is optional.
>
Will fix.
>> + #include <dt-bindings/clock/starfive-jh7110.h>
>> + #include <dt-bindings/reset/starfive-jh7110.h>
>> + mmc@...10000 {
>> + compatible = "starfive,jh7110-sdio";
>> + reg = <0x16010000 0x10000>;
>
> No syscon phandle in the example: this needs to be added.
>
I will add the syscon phandle.
Thank you for taking time to review and provide helpful comments for this patch.
Best regards,
William Qiu
> Yours,
> Linus Walleij
Powered by blists - more mailing lists