[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y5F7i8Ee/jAQKu9n@atomide.com>
Date: Thu, 8 Dec 2022 07:52:11 +0200
From: Tony Lindgren <tony@...mide.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
Jiri Slaby <jirislaby@...nel.org>,
Johan Hovold <johan@...nel.org>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Vignesh Raghavendra <vigneshr@...com>,
linux-serial@...r.kernel.org, linux-omap@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v4 1/1] serial: core: Start managing serial
controllers to enable runtime PM
* Andy Shevchenko <andriy.shevchenko@...el.com> [221207 20:28]:
> We can avoid this check by caching the platform device.
>
> struct platform_device *ctrl_pdev = NULL;
>
> if (...) {
> ctrl_pdev = to_platform_device(ctrl_dev);
> }
>
> platform_device_del(ctrl_pdev);
OK yeah that's nicer :)
> > Shouldn't you call platform_device_unregister()?
Outside the error path it should be platform_device_unregister(),
I'll check. Thanks also for your other comments.
Regards,
Tony
Powered by blists - more mailing lists