linux-kernel - Re: [RFC PATCH v4 1/1] serial: core: Start managing serial controllers to enable runtime PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5F+5kAAr7pMeGWE@atomide.com>
Date:   Thu, 8 Dec 2022 08:06:30 +0200
From:   Tony Lindgren <tony@...mide.com>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Johan Hovold <johan@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-serial@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v4 1/1] serial: core: Start managing serial
 controllers to enable runtime PM

* Tony Lindgren <tony@...mide.com> [221208 05:52]:
> * Andy Shevchenko <andriy.shevchenko@...el.com> [221207 20:28]:
> > We can avoid this check by caching the platform device.
> > 
> > 	struct platform_device *ctrl_pdev = NULL;
> > 
> > 	if (...) {
> > 		ctrl_pdev = to_platform_device(ctrl_dev);
> > 	}
> > 
> > 	platform_device_del(ctrl_pdev);
> 
> OK yeah that's nicer :)
> 
> > > Shouldn't you call platform_device_unregister()?
> 
> Outside the error path it should be platform_device_unregister(),
> I'll check. Thanks also for your other comments.

To me looks like we should just use platform_device_unregister()
in call cases here like you noted.

Regards,

Tony