linux-kernel - Re: [PATCH v2 1/4] media: ipu3-cio2: Don't dereference fwnode handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y5G99yAmflKJpF32@alley>
Date:   Thu, 8 Dec 2022 11:35:35 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Clément Léger <clement.leger@...tlin.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Daniel Scally <djrscally@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Yong Zhi <yong.zhi@...el.com>,
        Bingbu Cao <bingbu.cao@...el.com>,
        Tianshu Qiu <tian.shu.qiu@...el.com>,
        Daniel Scally <dan.scally@...asonboard.com>,
        Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: [PATCH v2 1/4] media: ipu3-cio2: Don't dereference fwnode handle

On Wed 2022-12-07 11:53:12, Andy Shevchenko wrote:
> On Wed, Dec 07, 2022 at 09:02:49AM +0000, Sakari Ailus wrote:
> > On Wed, Nov 23, 2022 at 09:10:58PM +0200, Andy Shevchenko wrote:
> > > Dunno what happened to my previous reply to this. Okay, trying again...
> > > 
> > > + Cc: Petr, Sergey
> > > 
> > > On Mon, Nov 21, 2022 at 05:27:01PM +0200, Andy Shevchenko wrote:
> > > > Use acpi_fwnode_handle() instead of dereferencing an fwnode handle directly,
> > > > which is a better coding practice.
> > > 
> > > It appears that this series depends on fd070e8ceb90 ("test_printf: Refactor
> > > fwnode_pointer() to make it more readable") which is in PRINTK tree.
> > > 
> > > Sakari, Mauro, if you are okay to route this via that tree, can we get your
> > > tags for that? Otherwise we need to postpone this till v6.2-rc1 (but I would
> > > like to decrease the chances to appear a new user of the to be removed API).
> > > 
> > > Note, that Greg Acked v1 of the swnode patches (which are the same in v2).
> > 
> > Sorry for the late reply. Feel free to do that if it's not too late, with:
> > 
> > Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> 
> Thank you!
> I think it's a bit late for printk tree to consume this. If it's the case
> (Petr?) then I will submit a new version after v6.2-rc1 is out.

Yes, I am sorry but it is too late for the printk tree. I am going to
send the pull request for 6.2 today or tomorrow. Linus explicitly
asked to send the pull request early this time because the merge
window will be overlapping with the holidays.

On the positive side. There is a high chance that the changes from
the printk tree will be in the mainline early enough so that you
could manage to send this still during the merge window.

Best Regards,
Petr