linux-kernel - RE: [PATCH v4 2/4] ufs: core: Remove redundant desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR04MB632742AD2ADF3C53EEA94F95ED1D9@BY5PR04MB6327.namprd04.prod.outlook.com>
Date:   Thu, 8 Dec 2022 12:48:06 +0000
From:   Arthur Simchaev <Arthur.Simchaev@....com>
To:     Bart Van Assche <bvanassche@....org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 2/4] ufs: core: Remove redundant desc_size variable
 from hba

> 
> Comments should explain something that is nontrivial instead of duplicating
> the
> code. Additionally, this change makes ufshcd_map_desc_id_to_length() too
> short
> too keep it as a function. Please remove this function entirely and insert the
> following code into the callers of this function:
> 
> desc_len = QUERY_DESC_MAX_SIZE
> 
> Thanks,
> 
> Bart.

Done

Regards
Arthur