linux-kernel - Re: [PATCH] kvm: Remove the unused macro KVM_MMU_READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c958aa5a-1bd2-7f81-0f20-fd3a42393528@redhat.com>
Date:   Fri, 9 Dec 2022 08:58:03 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Sean Christopherson <seanjc@...gle.com>,
        Lai Jiangshan <jiangshan.ljs@...group.com>, kvm@...r.kernel.org
Subject: Re: [PATCH] kvm: Remove the unused macro KVM_MMU_READ_LOCK()

On 12/7/22 13:06, Lai Jiangshan wrote:
> From: Lai Jiangshan <jiangshan.ljs@...group.com>
> 
> No code is using KVM_MMU_READ_LOCK().

And KVM_MMU_READ_UNLOCK() is also unused.

Paolo

> Signed-off-by: Lai Jiangshan <jiangshan.ljs@...group.com>
> ---
>   virt/kvm/kvm_mm.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/virt/kvm/kvm_mm.h b/virt/kvm/kvm_mm.h
> index a1ab15006af3..e98e294080bf 100644
> --- a/virt/kvm/kvm_mm.h
> +++ b/virt/kvm/kvm_mm.h
> @@ -14,13 +14,11 @@
>   #define KVM_MMU_LOCK_INIT(kvm)		rwlock_init(&(kvm)->mmu_lock)
>   #define KVM_MMU_LOCK(kvm)		write_lock(&(kvm)->mmu_lock)
>   #define KVM_MMU_UNLOCK(kvm)		write_unlock(&(kvm)->mmu_lock)
> -#define KVM_MMU_READ_LOCK(kvm)		read_lock(&(kvm)->mmu_lock)
>   #define KVM_MMU_READ_UNLOCK(kvm)	read_unlock(&(kvm)->mmu_lock)
>   #else
>   #define KVM_MMU_LOCK_INIT(kvm)		spin_lock_init(&(kvm)->mmu_lock)
>   #define KVM_MMU_LOCK(kvm)		spin_lock(&(kvm)->mmu_lock)
>   #define KVM_MMU_UNLOCK(kvm)		spin_unlock(&(kvm)->mmu_lock)
> -#define KVM_MMU_READ_LOCK(kvm)		spin_lock(&(kvm)->mmu_lock)
>   #define KVM_MMU_READ_UNLOCK(kvm)	spin_unlock(&(kvm)->mmu_lock)
>   #endif /* KVM_HAVE_MMU_RWLOCK */
>