linux-kernel - Re: [PATCH] kvm: x86/mmu: Remove duplicated "be split" in spte.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <372a8ea3-6a87-5eb4-0712-ce48e85ba58e@redhat.com>
Date:   Fri, 9 Dec 2022 08:58:35 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Lai Jiangshan <jiangshan.ljs@...group.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, kvm@...r.kernel.org
Subject: Re: [PATCH] kvm: x86/mmu: Remove duplicated "be split" in spte.h

On 12/7/22 13:05, Lai Jiangshan wrote:
> From: Lai Jiangshan <jiangshan.ljs@...group.com>
> 
> "be split be split" -> "be split"
> 
> Signed-off-by: Lai Jiangshan <jiangshan.ljs@...group.com>
> ---
>   arch/x86/kvm/mmu/spte.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/mmu/spte.h b/arch/x86/kvm/mmu/spte.h
> index 1f03701b943a..6f54dc9409c9 100644
> --- a/arch/x86/kvm/mmu/spte.h
> +++ b/arch/x86/kvm/mmu/spte.h
> @@ -363,7 +363,7 @@ static __always_inline bool is_rsvd_spte(struct rsvd_bits_validate *rsvd_check,
>    * A shadow-present leaf SPTE may be non-writable for 4 possible reasons:
>    *
>    *  1. To intercept writes for dirty logging. KVM write-protects huge pages
> - *     so that they can be split be split down into the dirty logging
> + *     so that they can be split down into the dirty logging
>    *     granularity (4KiB) whenever the guest writes to them. KVM also
>    *     write-protects 4KiB pages so that writes can be recorded in the dirty log
>    *     (e.g. if not using PML). SPTEs are write-protected for dirty logging

Queued, thanks.

Paolo