linux-kernel - Re: [PATCH v1] ASoC: Intel: sof_nau8825: add support for nau8825 with amp nau8318

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22043956-e18c-9ed6-5091-188ae40f3cd9@linux.intel.com>
Date:   Fri, 9 Dec 2022 11:31:24 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Ajye Huang <ajye_huang@...pal.corp-partner.google.com>
Cc:     Libin Yang <libin.yang@...el.com>,
        "balamurugan . c" <balamurugan.c@...el.com>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        Muralidhar Reddy <muralidhar.reddy@...el.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Akihiko Odaki <akihiko.odaki@...il.com>,
        ye xingchen <ye.xingchen@....com.cn>,
        David Lin <CTLIN0@...oton.com>, alsa-devel@...a-project.org,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Brent Lu <brent.lu@...el.com>, Yong Zhi <yong.zhi@...el.com>
Subject: Re: [PATCH v1] ASoC: Intel: sof_nau8825: add support for nau8825 with
 amp nau8318




>> This looks inconsistent with the commit message. There are separate
>> Kconfigs for different codecs.
>>
>> SND_SOC_NAU8315
>> SND_SOC_NAU8825
>>
>> Which is it?
>>
> 
> Sorry about confusing you, I think it is better to change the title as
> ASoC: Intel: sof_nau8825: add combination of nau8825 headset codec
> with nau8318 Amp.

Suggested edit:

ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier.

> 
> And add some information about Nuvoton chips in the comment message.
> ***
> The nau8315 and nau8318 are both Nuvoton Amp chips. They use the same
> Amp driver nau8315.c. The acpi_device_id for nau8315 is "NVTN2010",
> for nau8318 is "NVTN2012".

That should be added in the commit message please.

>> NAK for this v1. Please clarify which codec you are using and make sure
>> all references are consistent.
>>
>>
> 
> I apologize for the unclear comment message, please give me any
> suggestions if needed, and I will send v2 for review.
> thanks.

Ok, makes sense now. Please do include the explanations on 8315/8318
variants, I couldn't figure out what chips were used.

I would also not use the same topology name as a different platform with
another amplifier. I appreciate you trying to reuse when possible, but
it's just better to create a new topology file. That way if you want any
update down the road you can do so, it's more maintainable and risk-free.