linux-kernel - Re: [PATCH v1] ASoC: Intel: sof_nau8825: add support for nau8825 with amp nau8318

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALprXBbxb_m_ieAi9VohZE+yUpyJ51rGE2VuskJpgNabB-gRCQ@mail.gmail.com>
Date:   Sat, 10 Dec 2022 01:51:10 +0800
From:   Ajye Huang <ajye_huang@...pal.corp-partner.google.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     Libin Yang <libin.yang@...el.com>,
        "balamurugan . c" <balamurugan.c@...el.com>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        Muralidhar Reddy <muralidhar.reddy@...el.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Akihiko Odaki <akihiko.odaki@...il.com>,
        ye xingchen <ye.xingchen@....com.cn>,
        David Lin <CTLIN0@...oton.com>, alsa-devel@...a-project.org,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Brent Lu <brent.lu@...el.com>, Yong Zhi <yong.zhi@...el.com>
Subject: Re: [PATCH v1] ASoC: Intel: sof_nau8825: add support for nau8825 with
 amp nau8318

HI Pierre,

On Sat, Dec 10, 2022 at 1:31 AM Pierre-Louis Bossart
<pierre-louis.bossart@...ux.intel.com> wrote:

> Suggested edit:
>
> ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier.
>

> That should be added in the commit message please.
>

Thank you for the suggestion title and I will add those explanations
in the comment message.

> Ok, makes sense now. Please do include the explanations on 8315/8318
> variants, I couldn't figure out what chips were used.
>
> I would also not use the same topology name as a different platform with
> another amplifier. I appreciate you trying to reuse when possible, but
> it's just better to create a new topology file. That way if you want any
> update down the road you can do so, it's more maintainable and risk-free.

OK, The v2 patch will be sent after the new topology file is created. Thank you.