[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221210084619.GA21743@1wt.eu>
Date: Sat, 10 Dec 2022 09:46:19 +0100
From: Willy Tarreau <w@....eu>
To: Sven Schnelle <svens@...ux.ibm.com>
Cc: "Paul E . McKenney" <paulmck@...nel.org>,
Josh Triplett <josh@...htriplett.org>,
Steven Rostedt <rostedt@...dmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Lai Jiangshan <jiangshanlai@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] nolibc: fix fd_set type
On Fri, Dec 09, 2022 at 03:19:35PM +0100, Sven Schnelle wrote:
> The kernel uses unsigned long for the fd_set bitmap,
> but nolibc use u32. This works fine on little endian
> machines, but fails on big endian. Convert to unsigned
> long to fix this.
Thank you for spotting and fixing this one! I had been using these for
a long time, including for pure user-land code to manipulate bits and
never thought about the risk of incompatibility when passing them as-is
to the kernel! It's fairly possible that I'm having non-working code for
64-bit BE machines at a few places!
> Signed-off-by: Sven Schnelle <svens@...ux.ibm.com>
Acked-by: Willy Tarreau <w@....eu>
Willy
Powered by blists - more mailing lists