linux-kernel - [PATCH] <driver/net/ethernet/amd/nmclan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221210084713.51710-1-akaritakahashioss@gmail.com>
Date:   Sat, 10 Dec 2022 17:47:13 +0900
From:   Takahashi Akari <akaritakahashioss@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     Takahashi Akari <akaritakahashioss@...il.com>
Subject: [PATCH] <driver/net/ethernet/amd/nmclan_cs.c> Remove unnecessary line

Hello:

I sent a patch. Please review and merge.

Reason:
Remove unnecessaty line. (if statement is always true)

Git repository URL:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

File:
drivers/net/ethernet/amd/nmclan_cs.c : 931

Signed-off-by: Takahashi Akari <akaritakahashioss@...il.com>
---
 drivers/net/ethernet/amd/nmclan_cs.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c
index 823a329a921f..a90e0c5b603d 100644
--- a/drivers/net/ethernet/amd/nmclan_cs.c
+++ b/drivers/net/ethernet/amd/nmclan_cs.c
@@ -928,10 +928,7 @@ static irqreturn_t mace_interrupt(int irq, void *dev_id)
 
   if (lp->tx_irq_disabled) {
     const char *msg;
-    if (lp->tx_irq_disabled)
-      msg = "Interrupt with tx_irq_disabled";
-    else
-      msg = "Re-entering the interrupt handler";
+    msg = "Interrupt with tx_irq_disabled";
     netdev_notice(dev, "%s [isr=%02X, imr=%02X]\n",
 		  msg,
 		  inb(ioaddr + AM2150_MACE_BASE + MACE_IR),
-- 
2.34.1