lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 14 Dec 2022 01:28:28 +0800
From:   kernel test robot <lkp@...el.com>
To:     Liming Wu <liming.wu@...uarmicro.com>, bhelgaas@...gle.com
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Liming Wu <liming.wu@...uarmicro.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        alex.williamson@...hat.com, 398776277@...com
Subject: Re: [PATCH] PCI/IOV: Expose error return to dmesg

Hi Liming,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on helgaas-pci/for-linus linus/master v6.1 next-20221213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Liming-Wu/PCI-IOV-Expose-error-return-to-dmesg/20221213-161738
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
patch link:    https://lore.kernel.org/r/20221213081607.1641-1-liming.wu%40jaguarmicro.com
patch subject: [PATCH] PCI/IOV: Expose error return to dmesg
config: i386-randconfig-a013
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/c1d53738a3ff4c33e1c442c3b9ad02377be02eaa
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Liming-Wu/PCI-IOV-Expose-error-return-to-dmesg/20221213-161738
        git checkout c1d53738a3ff4c33e1c442c3b9ad02377be02eaa
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from drivers/pci/access.c:8:
>> drivers/pci/pci.h:489:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
   }
   ^
   1 error generated.
--
   In file included from drivers/pci/msi/pcidev_msi.c:5:
>> drivers/pci/msi/../pci.h:489:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
   }
   ^
   1 error generated.
--
   In file included from drivers/pci/controller/pcie-xilinx.c:27:
>> drivers/pci/controller/../pci.h:489:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
   }
   ^
   1 error generated.
--
   In file included from drivers/pci/controller/dwc/pcie-designware.c:22:
>> drivers/pci/controller/dwc/../../pci.h:489:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
   }
   ^
   1 error generated.


vim +489 drivers/pci/pci.h

751035b8dc061a Kuppuswamy Sathyanarayanan 2019-09-05  475  
d1b054da8f5999 Yu Zhao                    2009-03-20  476  #ifdef CONFIG_PCI_IOV
f39d5b72913e2a Bjorn Helgaas              2013-04-12  477  int pci_iov_init(struct pci_dev *dev);
f39d5b72913e2a Bjorn Helgaas              2013-04-12  478  void pci_iov_release(struct pci_dev *dev);
38972375ef7bdc Jakub Kicinski             2018-06-29  479  void pci_iov_remove(struct pci_dev *dev);
6ffa2489c51da7 Bjorn Helgaas              2016-11-28  480  void pci_iov_update_resource(struct pci_dev *dev, int resno);
f39d5b72913e2a Bjorn Helgaas              2013-04-12  481  resource_size_t pci_sriov_resource_alignment(struct pci_dev *dev, int resno);
f39d5b72913e2a Bjorn Helgaas              2013-04-12  482  void pci_restore_iov_state(struct pci_dev *dev);
f39d5b72913e2a Bjorn Helgaas              2013-04-12  483  int pci_iov_bus_range(struct pci_bus *bus);
c3d5c2d96d69f2 Leon Romanovsky            2021-04-04  484  extern const struct attribute_group sriov_pf_dev_attr_group;
c3d5c2d96d69f2 Leon Romanovsky            2021-04-04  485  extern const struct attribute_group sriov_vf_dev_attr_group;
d1b054da8f5999 Yu Zhao                    2009-03-20  486  #else
d1b054da8f5999 Yu Zhao                    2009-03-20  487  static inline int pci_iov_init(struct pci_dev *dev)
d1b054da8f5999 Yu Zhao                    2009-03-20  488  {
d1b054da8f5999 Yu Zhao                    2009-03-20 @489  }
d1b054da8f5999 Yu Zhao                    2009-03-20  490  static inline void pci_iov_release(struct pci_dev *dev)
38972375ef7bdc Jakub Kicinski             2018-06-29  491  {
38972375ef7bdc Jakub Kicinski             2018-06-29  492  }
38972375ef7bdc Jakub Kicinski             2018-06-29  493  static inline void pci_iov_remove(struct pci_dev *dev)
d1b054da8f5999 Yu Zhao                    2009-03-20  494  {
d1b054da8f5999 Yu Zhao                    2009-03-20  495  }
8c5cdb6adc6688 Yu Zhao                    2009-03-20  496  static inline void pci_restore_iov_state(struct pci_dev *dev)
8c5cdb6adc6688 Yu Zhao                    2009-03-20  497  {
8c5cdb6adc6688 Yu Zhao                    2009-03-20  498  }
a28724b0fb909d Yu Zhao                    2009-03-20  499  static inline int pci_iov_bus_range(struct pci_bus *bus)
a28724b0fb909d Yu Zhao                    2009-03-20  500  {
a28724b0fb909d Yu Zhao                    2009-03-20  501  	return 0;
a28724b0fb909d Yu Zhao                    2009-03-20  502  }
302b4215daa0a7 Yu Zhao                    2009-05-18  503  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (155539 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ