linux-kernel - Re: [PATCH] PCI/IOV: Expose error return to dmesg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212140023.pXRHoQNv-lkp@intel.com>
Date:   Wed, 14 Dec 2022 00:48:03 +0800
From:   kernel test robot <lkp@...el.com>
To:     Liming Wu <liming.wu@...uarmicro.com>, bhelgaas@...gle.com
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Liming Wu <liming.wu@...uarmicro.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        alex.williamson@...hat.com, 398776277@...com
Subject: Re: [PATCH] PCI/IOV: Expose error return to dmesg

Hi Liming,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on helgaas-pci/for-linus linus/master v6.1 next-20221213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Liming-Wu/PCI-IOV-Expose-error-return-to-dmesg/20221213-161738
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
patch link:    https://lore.kernel.org/r/20221213081607.1641-1-liming.wu%40jaguarmicro.com
patch subject: [PATCH] PCI/IOV: Expose error return to dmesg
config: riscv-randconfig-r042-20221213
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 6e4cea55f0d1104408b26ac574566a0e4de48036)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/c1d53738a3ff4c33e1c442c3b9ad02377be02eaa
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Liming-Wu/PCI-IOV-Expose-error-return-to-dmesg/20221213-161738
        git checkout c1d53738a3ff4c33e1c442c3b9ad02377be02eaa
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/pci/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/pci/iov.c:905:3: error: non-void function 'pci_iov_init' should return a value [-Wreturn-type]
                   return;
                   ^
   drivers/pci/iov.c:911:2: error: non-void function 'pci_iov_init' should return a value [-Wreturn-type]
           return;
           ^
   2 errors generated.


vim +/pci_iov_init +905 drivers/pci/iov.c

   893	
   894	/**
   895	 * pci_iov_init - initialize the IOV capability
   896	 * @dev: the PCI device
   897	 *
   898	 * Returns 0 on success, or negative on failure.
   899	 */
   900	int pci_iov_init(struct pci_dev *dev)
   901	{
   902		int pos;
   903	
   904		if (!pci_is_pcie(dev))
 > 905			return;
   906	
   907		pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_SRIOV);
   908		if (pos)
   909			return sriov_init(dev, pos);
   910	
   911		return;
   912	}
   913	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (156219 bytes)