linux-kernel - Re: [PATCH] NFS: fix client permission error after adding user to permissible group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Dec 2022 20:13:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chengen Du <chengen.du@...onical.com>,
        trond.myklebust@...merspace.com
Cc:     oe-kbuild-all@...ts.linux.dev, anna@...nel.org,
        chuck.lever@...cle.com, jlayton@...nel.org,
        linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Chengen Du <chengen.du@...onical.com>
Subject: Re: [PATCH] NFS: fix client permission error after adding user to
 permissible group

Hi Chengen,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on trondmy-nfs/linux-next]
[also build test WARNING on linus/master v6.1 next-20221213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chengen-Du/NFS-fix-client-permission-error-after-adding-user-to-permissible-group/20221213-180531
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
patch link:    https://lore.kernel.org/r/20221213100241.254681-1-chengen.du%40canonical.com
patch subject: [PATCH] NFS: fix client permission error after adding user to permissible group
config: arc-defconfig
compiler: arc-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/7206036f9265a95f957d3f58a973c9ab27979284
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Chengen-Du/NFS-fix-client-permission-error-after-adding-user-to-permissible-group/20221213-180531
        git checkout 7206036f9265a95f957d3f58a973c9ab27979284
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash fs/nfs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/nfs/dir.c:2937:26: warning: no previous prototype for 'nfs_access_search_rbtree' [-Wmissing-prototypes]
    2937 | struct nfs_access_entry *nfs_access_search_rbtree(struct inode *inode, const struct cred *cred)
         |                          ^~~~~~~~~~~~~~~~~~~~~~~~
--
   fs/nfs/inode.c: In function 'nfs_update_inode':
   fs/nfs/inode.c:2186:33: error: implicit declaration of function 'nfs_access_search_rbtree' [-Werror=implicit-function-declaration]
    2186 |                         cache = nfs_access_search_rbtree(inode, cred);
         |                                 ^~~~~~~~~~~~~~~~~~~~~~~~
>> fs/nfs/inode.c:2186:31: warning: assignment to 'struct nfs_access_entry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    2186 |                         cache = nfs_access_search_rbtree(inode, cred);
         |                               ^
   cc1: some warnings being treated as errors


vim +/nfs_access_search_rbtree +2937 fs/nfs/dir.c

  2936	
> 2937	struct nfs_access_entry *nfs_access_search_rbtree(struct inode *inode, const struct cred *cred)
  2938	{
  2939		struct rb_node *n = NFS_I(inode)->access_cache.rb_node;
  2940	
  2941		while (n != NULL) {
  2942			struct nfs_access_entry *entry =
  2943				rb_entry(n, struct nfs_access_entry, rb_node);
  2944			int cmp = access_cmp(cred, entry);
  2945	
  2946			if (cmp < 0)
  2947				n = n->rb_left;
  2948			else if (cmp > 0)
  2949				n = n->rb_right;
  2950			else
  2951				return entry;
  2952		}
  2953		return NULL;
  2954	}
  2955	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (39743 bytes)