| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202212132050.Na6BkFmL-lkp@intel.com>
Date: Tue, 13 Dec 2022 20:54:26 +0800
From: kernel test robot <lkp@...el.com>
To: Chengen Du <chengen.du@...onical.com>,
trond.myklebust@...merspace.com
Cc: oe-kbuild-all@...ts.linux.dev, anna@...nel.org,
chuck.lever@...cle.com, jlayton@...nel.org,
linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
Chengen Du <chengen.du@...onical.com>
Subject: Re: [PATCH] NFS: fix client permission error after adding user to
permissible group
Hi Chengen,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on trondmy-nfs/linux-next]
[also build test ERROR on linus/master v6.1 next-20221213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chengen-Du/NFS-fix-client-permission-error-after-adding-user-to-permissible-group/20221213-180531
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
patch link: https://lore.kernel.org/r/20221213100241.254681-1-chengen.du%40canonical.com
patch subject: [PATCH] NFS: fix client permission error after adding user to permissible group
config: arc-defconfig
compiler: arc-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/7206036f9265a95f957d3f58a973c9ab27979284
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Chengen-Du/NFS-fix-client-permission-error-after-adding-user-to-permissible-group/20221213-180531
git checkout 7206036f9265a95f957d3f58a973c9ab27979284
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
fs/nfs/inode.c: In function 'nfs_update_inode':
>> fs/nfs/inode.c:2186:33: error: implicit declaration of function 'nfs_access_search_rbtree' [-Werror=implicit-function-declaration]
2186 | cache = nfs_access_search_rbtree(inode, cred);
| ^~~~~~~~~~~~~~~~~~~~~~~~
fs/nfs/inode.c:2186:31: warning: assignment to 'struct nfs_access_entry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
2186 | cache = nfs_access_search_rbtree(inode, cred);
| ^
cc1: some warnings being treated as errors
vim +/nfs_access_search_rbtree +2186 fs/nfs/inode.c
1970
1971
1972 /*
1973 * Many nfs protocol calls return the new file attributes after
1974 * an operation. Here we update the inode to reflect the state
1975 * of the server's inode.
1976 *
1977 * This is a bit tricky because we have to make sure all dirty pages
1978 * have been sent off to the server before calling invalidate_inode_pages.
1979 * To make sure no other process adds more write requests while we try
1980 * our best to flush them, we make them sleep during the attribute refresh.
1981 *
1982 * A very similar scenario holds for the dir cache.
1983 */
1984 static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr)
1985 {
1986 struct nfs_server *server = NFS_SERVER(inode);
1987 struct nfs_inode *nfsi = NFS_I(inode);
1988 loff_t cur_isize, new_isize;
1989 u64 fattr_supported = server->fattr_valid;
1990 unsigned long invalid = 0;
1991 unsigned long now = jiffies;
1992 unsigned long save_cache_validity;
1993 bool have_writers = nfs_file_has_buffered_writers(nfsi);
1994 bool cache_revalidated = true;
1995 bool attr_changed = false;
1996 bool have_delegation;
1997
1998 dfprintk(VFS, "NFS: %s(%s/%lu fh_crc=0x%08x ct=%d info=0x%x)\n",
1999 __func__, inode->i_sb->s_id, inode->i_ino,
2000 nfs_display_fhandle_hash(NFS_FH(inode)),
2001 atomic_read(&inode->i_count), fattr->valid);
2002
2003 if (!(fattr->valid & NFS_ATTR_FATTR_FILEID)) {
2004 /* Only a mounted-on-fileid? Just exit */
2005 if (fattr->valid & NFS_ATTR_FATTR_MOUNTED_ON_FILEID)
2006 return 0;
2007 /* Has the inode gone and changed behind our back? */
2008 } else if (nfsi->fileid != fattr->fileid) {
2009 /* Is this perhaps the mounted-on fileid? */
2010 if ((fattr->valid & NFS_ATTR_FATTR_MOUNTED_ON_FILEID) &&
2011 nfsi->fileid == fattr->mounted_on_fileid)
2012 return 0;
2013 printk(KERN_ERR "NFS: server %s error: fileid changed\n"
2014 "fsid %s: expected fileid 0x%Lx, got 0x%Lx\n",
2015 NFS_SERVER(inode)->nfs_client->cl_hostname,
2016 inode->i_sb->s_id, (long long)nfsi->fileid,
2017 (long long)fattr->fileid);
2018 goto out_err;
2019 }
2020
2021 /*
2022 * Make sure the inode's type hasn't changed.
2023 */
2024 if ((fattr->valid & NFS_ATTR_FATTR_TYPE) && inode_wrong_type(inode, fattr->mode)) {
2025 /*
2026 * Big trouble! The inode has become a different object.
2027 */
2028 printk(KERN_DEBUG "NFS: %s: inode %lu mode changed, %07o to %07o\n",
2029 __func__, inode->i_ino, inode->i_mode, fattr->mode);
2030 goto out_err;
2031 }
2032
2033 /* Update the fsid? */
2034 if (S_ISDIR(inode->i_mode) && (fattr->valid & NFS_ATTR_FATTR_FSID) &&
2035 !nfs_fsid_equal(&server->fsid, &fattr->fsid) &&
2036 !IS_AUTOMOUNT(inode))
2037 server->fsid = fattr->fsid;
2038
2039 /* Save the delegation state before clearing cache_validity */
2040 have_delegation = nfs_have_delegated_attributes(inode);
2041
2042 /*
2043 * Update the read time so we don't revalidate too often.
2044 */
2045 nfsi->read_cache_jiffies = fattr->time_start;
2046
2047 save_cache_validity = nfsi->cache_validity;
2048 nfsi->cache_validity &= ~(NFS_INO_INVALID_ATTR
2049 | NFS_INO_INVALID_ATIME
2050 | NFS_INO_REVAL_FORCED
2051 | NFS_INO_INVALID_BLOCKS);
2052
2053 /* Do atomic weak cache consistency updates */
2054 nfs_wcc_update_inode(inode, fattr);
2055
2056 if (pnfs_layoutcommit_outstanding(inode)) {
2057 nfsi->cache_validity |=
2058 save_cache_validity &
2059 (NFS_INO_INVALID_CHANGE | NFS_INO_INVALID_CTIME |
2060 NFS_INO_INVALID_MTIME | NFS_INO_INVALID_SIZE |
2061 NFS_INO_INVALID_BLOCKS);
2062 cache_revalidated = false;
2063 }
2064
2065 /* More cache consistency checks */
2066 if (fattr->valid & NFS_ATTR_FATTR_CHANGE) {
2067 if (!inode_eq_iversion_raw(inode, fattr->change_attr)) {
2068 /* Could it be a race with writeback? */
2069 if (!(have_writers || have_delegation)) {
2070 invalid |= NFS_INO_INVALID_DATA
2071 | NFS_INO_INVALID_ACCESS
2072 | NFS_INO_INVALID_ACL
2073 | NFS_INO_INVALID_XATTR;
2074 /* Force revalidate of all attributes */
2075 save_cache_validity |= NFS_INO_INVALID_CTIME
2076 | NFS_INO_INVALID_MTIME
2077 | NFS_INO_INVALID_SIZE
2078 | NFS_INO_INVALID_BLOCKS
2079 | NFS_INO_INVALID_NLINK
2080 | NFS_INO_INVALID_MODE
2081 | NFS_INO_INVALID_OTHER;
2082 if (S_ISDIR(inode->i_mode))
2083 nfs_force_lookup_revalidate(inode);
2084 attr_changed = true;
2085 dprintk("NFS: change_attr change on server for file %s/%ld\n",
2086 inode->i_sb->s_id,
2087 inode->i_ino);
2088 } else if (!have_delegation)
2089 nfsi->cache_validity |= NFS_INO_DATA_INVAL_DEFER;
2090 inode_set_iversion_raw(inode, fattr->change_attr);
2091 }
2092 } else {
2093 nfsi->cache_validity |=
2094 save_cache_validity & NFS_INO_INVALID_CHANGE;
2095 if (!have_delegation ||
2096 (nfsi->cache_validity & NFS_INO_INVALID_CHANGE) != 0)
2097 cache_revalidated = false;
2098 }
2099
2100 if (fattr->valid & NFS_ATTR_FATTR_MTIME)
2101 inode->i_mtime = fattr->mtime;
2102 else if (fattr_supported & NFS_ATTR_FATTR_MTIME)
2103 nfsi->cache_validity |=
2104 save_cache_validity & NFS_INO_INVALID_MTIME;
2105
2106 if (fattr->valid & NFS_ATTR_FATTR_CTIME)
2107 inode->i_ctime = fattr->ctime;
2108 else if (fattr_supported & NFS_ATTR_FATTR_CTIME)
2109 nfsi->cache_validity |=
2110 save_cache_validity & NFS_INO_INVALID_CTIME;
2111
2112 /* Check if our cached file size is stale */
2113 if (fattr->valid & NFS_ATTR_FATTR_SIZE) {
2114 new_isize = nfs_size_to_loff_t(fattr->size);
2115 cur_isize = i_size_read(inode);
2116 if (new_isize != cur_isize && !have_delegation) {
2117 /* Do we perhaps have any outstanding writes, or has
2118 * the file grown beyond our last write? */
2119 if (!nfs_have_writebacks(inode) || new_isize > cur_isize) {
2120 trace_nfs_size_update(inode, new_isize);
2121 i_size_write(inode, new_isize);
2122 if (!have_writers)
2123 invalid |= NFS_INO_INVALID_DATA;
2124 }
2125 }
2126 if (new_isize == 0 &&
2127 !(fattr->valid & (NFS_ATTR_FATTR_SPACE_USED |
2128 NFS_ATTR_FATTR_BLOCKS_USED))) {
2129 fattr->du.nfs3.used = 0;
2130 fattr->valid |= NFS_ATTR_FATTR_SPACE_USED;
2131 }
2132 } else
2133 nfsi->cache_validity |=
2134 save_cache_validity & NFS_INO_INVALID_SIZE;
2135
2136 if (fattr->valid & NFS_ATTR_FATTR_ATIME)
2137 inode->i_atime = fattr->atime;
2138 else if (fattr_supported & NFS_ATTR_FATTR_ATIME)
2139 nfsi->cache_validity |=
2140 save_cache_validity & NFS_INO_INVALID_ATIME;
2141
2142 if (fattr->valid & NFS_ATTR_FATTR_MODE) {
2143 if ((inode->i_mode & S_IALLUGO) != (fattr->mode & S_IALLUGO)) {
2144 umode_t newmode = inode->i_mode & S_IFMT;
2145 newmode |= fattr->mode & S_IALLUGO;
2146 inode->i_mode = newmode;
2147 invalid |= NFS_INO_INVALID_ACCESS
2148 | NFS_INO_INVALID_ACL;
2149 }
2150 } else if (fattr_supported & NFS_ATTR_FATTR_MODE)
2151 nfsi->cache_validity |=
2152 save_cache_validity & NFS_INO_INVALID_MODE;
2153
2154 if (fattr->valid & NFS_ATTR_FATTR_OWNER) {
2155 if (!uid_eq(inode->i_uid, fattr->uid)) {
2156 invalid |= NFS_INO_INVALID_ACCESS
2157 | NFS_INO_INVALID_ACL;
2158 inode->i_uid = fattr->uid;
2159 }
2160 } else if (fattr_supported & NFS_ATTR_FATTR_OWNER)
2161 nfsi->cache_validity |=
2162 save_cache_validity & NFS_INO_INVALID_OTHER;
2163
2164 if (fattr->valid & NFS_ATTR_FATTR_GROUP) {
2165 if (!gid_eq(inode->i_gid, fattr->gid)) {
2166 invalid |= NFS_INO_INVALID_ACCESS
2167 | NFS_INO_INVALID_ACL;
2168 inode->i_gid = fattr->gid;
2169 }
2170 } else if (fattr_supported & NFS_ATTR_FATTR_GROUP)
2171 nfsi->cache_validity |=
2172 save_cache_validity & NFS_INO_INVALID_OTHER;
2173
2174 if (fattr->valid & NFS_ATTR_FATTR_NLINK) {
2175 if (inode->i_nlink != fattr->nlink)
2176 set_nlink(inode, fattr->nlink);
2177 } else if (fattr_supported & NFS_ATTR_FATTR_NLINK)
2178 nfsi->cache_validity |=
2179 save_cache_validity & NFS_INO_INVALID_NLINK;
2180
2181 if (fattr->valid & NFS_ATTR_FATTR_ACCESS) {
2182 if (!(invalid & NFS_INO_INVALID_ACCESS)) {
2183 const struct cred *cred = current_cred();
2184 struct nfs_access_entry *cache;
2185
> 2186 cache = nfs_access_search_rbtree(inode, cred);
2187 if (cache != NULL && cache->mask != fattr->access) {
2188 invalid |= NFS_INO_INVALID_ACCESS;
2189 }
2190 }
2191 }
2192
2193 if (fattr->valid & NFS_ATTR_FATTR_SPACE_USED) {
2194 /*
2195 * report the blocks in 512byte units
2196 */
2197 inode->i_blocks = nfs_calc_block_size(fattr->du.nfs3.used);
2198 } else if (fattr_supported & NFS_ATTR_FATTR_SPACE_USED)
2199 nfsi->cache_validity |=
2200 save_cache_validity & NFS_INO_INVALID_BLOCKS;
2201
2202 if (fattr->valid & NFS_ATTR_FATTR_BLOCKS_USED)
2203 inode->i_blocks = fattr->du.nfs2.blocks;
2204 else if (fattr_supported & NFS_ATTR_FATTR_BLOCKS_USED)
2205 nfsi->cache_validity |=
2206 save_cache_validity & NFS_INO_INVALID_BLOCKS;
2207
2208 /* Update attrtimeo value if we're out of the unstable period */
2209 if (attr_changed) {
2210 nfs_inc_stats(inode, NFSIOS_ATTRINVALIDATE);
2211 nfsi->attrtimeo = NFS_MINATTRTIMEO(inode);
2212 nfsi->attrtimeo_timestamp = now;
2213 /* Set barrier to be more recent than all outstanding updates */
2214 nfsi->attr_gencount = nfs_inc_attr_generation_counter();
2215 } else {
2216 if (cache_revalidated) {
2217 if (!time_in_range_open(now, nfsi->attrtimeo_timestamp,
2218 nfsi->attrtimeo_timestamp + nfsi->attrtimeo)) {
2219 nfsi->attrtimeo <<= 1;
2220 if (nfsi->attrtimeo > NFS_MAXATTRTIMEO(inode))
2221 nfsi->attrtimeo = NFS_MAXATTRTIMEO(inode);
2222 }
2223 nfsi->attrtimeo_timestamp = now;
2224 }
2225 /* Set the barrier to be more recent than this fattr */
2226 if ((long)(fattr->gencount - nfsi->attr_gencount) > 0)
2227 nfsi->attr_gencount = fattr->gencount;
2228 }
2229
2230 /* Don't invalidate the data if we were to blame */
2231 if (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode)
2232 || S_ISLNK(inode->i_mode)))
2233 invalid &= ~NFS_INO_INVALID_DATA;
2234 nfs_set_cache_invalid(inode, invalid);
2235
2236 return 0;
2237 out_err:
2238 /*
2239 * No need to worry about unhashing the dentry, as the
2240 * lookup validation will know that the inode is bad.
2241 * (But we fall through to invalidate the caches.)
2242 */
2243 nfs_set_inode_stale_locked(inode);
2244 return -ESTALE;
2245 }
2246
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (39743 bytes)
Powered by blists - more mailing lists