linux-kernel - Re: [PATCH] tracing: Fix cpumask() example typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221214162901.d0b51cea193aacc3148350b2@kernel.org>
Date:   Wed, 14 Dec 2022 16:29:01 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] tracing: Fix cpumask() example typo

On Tue, 13 Dec 2022 22:12:27 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: "Steven Rostedt (Google)" <rostedt@...dmis.org>
> 
> The sample code for using cpumask used the wrong field for the
> __get_cpumask() helper. It used "cpus" which is the bitmask (but would
> still give a proper example) instead of the "cpum" that was there to be
> used.
> 
> Although it produces the same output, fix it, because it's an example and
> is confusing in how to properly use the cpumask() macro.
> 

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Thanks,

> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
>  samples/trace_events/trace-events-sample.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h
> index fb4548a44153..1c6b843b8c4e 100644
> --- a/samples/trace_events/trace-events-sample.h
> +++ b/samples/trace_events/trace-events-sample.h
> @@ -359,7 +359,7 @@ TRACE_EVENT(foo_bar,
>  		  __print_array(__get_dynamic_array(list),
>  				__get_dynamic_array_len(list) / sizeof(int),
>  				sizeof(int)),
> -		  __get_str(str), __get_bitmask(cpus), __get_cpumask(cpus),
> +		  __get_str(str), __get_bitmask(cpus), __get_cpumask(cpum),
>  		  __get_str(vstr))
>  );
>  
> -- 
> 2.35.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>