linux-kernel - Re: [PATCH v10 016/108] KVM: TDX: create/destroy VM structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221215205937.GF3632095@ls.amr.corp.intel.com>
Date:   Thu, 15 Dec 2022 12:59:37 -0800
From:   Isaku Yamahata <isaku.yamahata@...il.com>
To:     Ackerley Tng <ackerleytng@...gle.com>
Cc:     isaku.yamahata@...el.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, isaku.yamahata@...il.com,
        pbonzini@...hat.com, erdemaktas@...gle.com, seanjc@...gle.com,
        sagis@...gle.com, dmatlack@...gle.com,
        sean.j.christopherson@...el.com, kai.huang@...el.com
Subject: Re: [PATCH v10 016/108] KVM: TDX: create/destroy VM structure

On Fri, Dec 09, 2022 at 11:15:35AM -0800,
Ackerley Tng <ackerleytng@...gle.com> wrote:

> 
> In tdx_vm_init, it is possible to have a double-reclaim, which
> eventually causes a host crash. I have a selftest that reliably
> reproduces this, and I believe the problem is that withiin
> tdx_vm_free(), we don't reset kvm->tdcs = NULL and kvm->tdr.added to
> false.

Thanks for the fix. Did you use error injection to trigger the error path?

Thanks,
-- 
Isaku Yamahata <isaku.yamahata@...il.com>