linux-kernel - Re: [PATCH mm-unstable] mm: move folio_set_compound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E39CAB80-2745-498C-8CDF-A469430F0276@linux.dev>
Date:   Thu, 15 Dec 2022 13:31:24 +0800
From:   Muchun Song <muchun.song@...ux.dev>
To:     Sidhartha Kumar <sidhartha.kumar@...cle.com>
Cc:     linux-kernel@...r.kernel.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Muchun Song <songmuchun@...edance.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Matthew Wilcox <willy@...radead.org>,
        John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to
 mm/internal.h



> On Dec 15, 2022, at 13:09, Sidhartha Kumar <sidhartha.kumar@...cle.com> wrote:
> 
> On 12/14/22 7:44 PM, Muchun Song wrote:
>>> On Dec 14, 2022, at 05:20, Sidhartha Kumar <sidhartha.kumar@...cle.com> wrote:
>>> 
>>> folio_set_compound_order() is moved to an mm-internal location so external
>>> folio users cannot misuse this function. Change the name of the function
>>> to folio_set_order() and use WARN_ON_ONCE() rather than BUG_ON. Also,
>>> handle the case if a non-large folio is passed and add clarifying comments
>>> to the function.
>>> 
>>> Link: https://lore.kernel.org/lkml/20221207223731.32784-1-sidhartha.kumar@oracle.com/T/
>>> Fixes: 9fd330582b2f ("mm: add folio dtor and order setter functions")
>>> 
>>> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>
>>> Suggested-by: Mike Kravetz <mike.kravetz@...cle.com>
>>> Suggested-by: Muchun Song <songmuchun@...edance.com>
>>> Suggested-by: Matthew Wilcox <willy@...radead.org>
>>> Suggested-by: John Hubbard <jhubbard@...dia.com>
>> Reviewed-by: Muchun Song <songmuchun@...edance.com>
> Hi Muchun,
> 
> Does this review include the change from

Yes.

Thanks.

> 
> + if (!folio_test_large(folio)) {
> + 	WARN_ON_ONCE(order);
> + 	return;
> + }
> 
> to
> 
> if (WARN_ON_ONCE(!folio_test_large(folio)))
> 	return;
> 
> discussed in in this thread?
> 
> Thanks,
> Sidhartha Kumar
>> Thanks.