linux-kernel - Re: [PATCH] PCI: Fix up L1SS capability for Intel Apollolake PCIe bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212151642.BgkMh90m-lkp@intel.com>
Date:   Thu, 15 Dec 2022 16:23:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ron Lee <ron.lee.intel@...il.com>, bhelgaas@...gle.com
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, lmajczak@...gle.com, rajatja@...gle.com,
        Ron Lee <ron.lee@...el.com>
Subject: Re: [PATCH] PCI: Fix up L1SS capability for Intel Apollolake PCIe
 bridge

Hi Ron,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on helgaas-pci/for-linus linus/master v6.1 next-20221215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ron-Lee/PCI-Fix-up-L1SS-capability-for-Intel-Apollolake-PCIe-bridge/20221215-115304
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
patch link:    https://lore.kernel.org/r/20221215034857.9076-1-ron.lee%40intel.com
patch subject: [PATCH] PCI: Fix up L1SS capability for Intel Apollolake PCIe bridge
config: i386-randconfig-a001
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/e387204fff704a3f10b2f3c8841407881bbefed8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ron-Lee/PCI-Fix-up-L1SS-capability-for-Intel-Apollolake-PCIe-bridge/20221215-115304
        git checkout e387204fff704a3f10b2f3c8841407881bbefed8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/pci/quirks.c: In function 'chromeos_fixup_apl_bridge_l1ss_capability':
>> drivers/pci/quirks.c:6005:42: error: 'struct pci_dev' has no member named 'l1ss'
    6005 |         pci_write_config_dword(pdev, pdev->l1ss, (0x220 << 20) | (1 << 16) | (PCI_EXT_CAP_ID_L1SS));
         |                                          ^~
   drivers/pci/quirks.c:6007:49: error: 'struct pci_dev' has no member named 'l1ss'
    6007 |         pci_write_config_dword(pdev, 0x150, pdev->l1ss << 20);
         |                                                 ^~


vim +6005 drivers/pci/quirks.c

  5995	
  5996	static void chromeos_fixup_apl_bridge_l1ss_capability(struct pci_dev *pdev)
  5997	{
  5998		if (!dmi_match(DMI_SYS_VENDOR, "Google") ||
  5999			(!dmi_match(DMI_PRODUCT_FAMILY, "Google_Coral") &&
  6000			 !dmi_match(DMI_PRODUCT_FAMILY, "Google_Reef")))
  6001			return;
  6002	
  6003		pci_info(pdev, "Fix up L1SS Capability\n");
  6004		/* Fix up the L1SS Capability Header*/
> 6005		pci_write_config_dword(pdev, pdev->l1ss, (0x220 << 20) | (1 << 16) | (PCI_EXT_CAP_ID_L1SS));

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (152909 bytes)