linux-kernel - Re: [PATCH] pinctrl: nomadik: include linux/seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2022 19:16:54 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Miaoqian Lin <linmq006@...il.com>,
        Marc Zyngier <maz@...nel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: nomadik: include linux/seq_file.h

On Thu, Dec 15, 2022 at 06:00:57PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> In some randconfig builds, the missing #include causes a
> build failure:
> 
> drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':
> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
>  1084 |         seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
>       |         ^~~~~~~~~~
>       |         bstr_printf

Hmm... Strange that I have not noticed this from CIs.
Nevertheless, I have a patch that adds more missing
headers to this driver. I have planned to send it
after v6.2-rc1.

I'm fine if this goes first. Up to Linus.

-- 
With Best Regards,
Andy Shevchenko