linux-kernel - Re: [PATCH] iommu/renesas: Support riscv compile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c10c9742-06d6-f56b-ea55-47f99b06ca32@arm.com>
Date:   Thu, 15 Dec 2022 17:16:41 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     guoren@...nel.org, palmer@...belt.com,
        prabhakar.mahadev-lad.rj@...renesas.com
Cc:     linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        iommu@...ts.linux.dev, Guo Ren <guoren@...ux.alibaba.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] iommu/renesas: Support riscv compile

On 2022-12-15 07:32, guoren@...nel.org wrote:
> From: Guo Ren <guoren@...ux.alibaba.com>
> 
> After riscv selects ARCH_RENESAS, we need to add ARM64 || ARM
> dependency here.

This effectively removes all the extra COMPILE_TEST coverage we've been 
enjoying. FWIW I prefer Geert's suggestion to separate the real 
functional dependency from implicit assumptions about ARCH_RENESAS, with 
something like:

	depends on ARCH_RENESAS || COMPILE_TEST
	depends on !GENERIC_ATOMIC64	#for IOMMU_IO_PGTABLE_LPAE

Thanks,
Robin.

> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@...nel.org>
> ---
>   drivers/iommu/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index dc5f7a156ff5..746b95b9f345 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -283,6 +283,7 @@ config EXYNOS_IOMMU_DEBUG
>   
>   config IPMMU_VMSA
>   	bool "Renesas VMSA-compatible IPMMU"
> +	depends on ARM64 || ARM
>   	depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64)
>   	select IOMMU_API
>   	select IOMMU_IO_PGTABLE_LPAE