linux-kernel - Re: [PATCH] cpufreq: apple: remove duplicate intializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Dec 2022 10:25:06 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Eric Curtin <ecurtin@...hat.com>
Cc:     Arnd Bergmann <arnd@...nel.org>, Hector Martin <marcan@...can.st>,
        Sven Peter <sven@...npeter.dev>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Marc Zyngier <maz@...nel.org>, asahi@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: apple: remove duplicate intializer

On 15-12-22, 17:10, Eric Curtin wrote:
> On Thu, 15 Dec 2022 at 17:05, Arnd Bergmann <arnd@...nel.org> wrote:
> >
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > When -Woverride-init is enabled, gcc notices that the .attr
> > field is initialized twice:
> >
> > drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init]
> >   331 |         .attr           = apple_soc_cpufreq_hw_attr,
> >       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Remove the first one, since this is not actually used.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Reviewed-by: Eric Curtin <ecurtin@...hat.com>

Applied. Thanks.

-- 
viresh