linux-kernel - Re: [PATCH] cpufreq: apple: remove duplicate intializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOgh=Fw4BXvGNV0bsTXfSxy+ks09ed=nbJhkOWE+UrT7LW+r6A@mail.gmail.com>
Date:   Thu, 15 Dec 2022 17:10:56 +0000
From:   Eric Curtin <ecurtin@...hat.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Marc Zyngier <maz@...nel.org>, asahi@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: apple: remove duplicate intializer

On Thu, 15 Dec 2022 at 17:05, Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> When -Woverride-init is enabled, gcc notices that the .attr
> field is initialized twice:
>
> drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init]
>   331 |         .attr           = apple_soc_cpufreq_hw_attr,
>       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Remove the first one, since this is not actually used.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Eric Curtin <ecurtin@...hat.com>

> ---
>  drivers/cpufreq/apple-soc-cpufreq.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-soc-cpufreq.c
> index d1801281cdd9..6f26395184c4 100644
> --- a/drivers/cpufreq/apple-soc-cpufreq.c
> +++ b/drivers/cpufreq/apple-soc-cpufreq.c
> @@ -321,7 +321,6 @@ static struct cpufreq_driver apple_soc_cpufreq_driver = {
>         .flags          = CPUFREQ_HAVE_GOVERNOR_PER_POLICY |
>                           CPUFREQ_NEED_INITIAL_FREQ_CHECK | CPUFREQ_IS_COOLING_DEV,
>         .verify         = cpufreq_generic_frequency_table_verify,
> -       .attr           = cpufreq_generic_attr,
>         .get            = apple_soc_cpufreq_get_rate,
>         .init           = apple_soc_cpufreq_init,
>         .exit           = apple_soc_cpufreq_exit,
> --
> 2.35.1
>
>