linux-kernel - Re: [PATCH RESENDv2] arm: topology: Consider clock-frequency property from parent /cpus node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5xqVmO9ZHWYW3Du@shell.armlinux.org.uk>
Date:   Fri, 16 Dec 2022 12:53:42 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Stefan Wiehler <stefan.wiehler@...ia.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESENDv2] arm: topology: Consider clock-frequency
 property from parent /cpus node

Hi,

On Fri, Dec 16, 2022 at 01:41:58PM +0100, Stefan Wiehler wrote:
> +	cn = of_get_cpu_node(cpu, NULL);
> +	if (!cn)
> +		pr_err("missing device node for CPU %d\n", cpu);
> +	cn = of_get_parent(cn);

Doesn't this need to do an of_node_put()?

> +	if (!cn)
> +		pr_err("missing parent node for CPU %d\n", cpu);
> +	common_rate = of_get_property(cn, "clock-frequency", &common_rate_len);

And here too?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!