[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bfdea5aa-13d5-338f-bb5d-c05df45f7859@nokia.com>
Date: Mon, 23 Jan 2023 10:08:41 +0100
From: Stefan Wiehler <stefan.wiehler@...ia.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESENDv2] arm: topology: Consider clock-frequency property
from parent /cpus node
Hi Russell,
>> + cn = of_get_cpu_node(cpu, NULL);
>> + if (!cn)
>> + pr_err("missing device node for CPU %d\n", cpu);
>> + cn = of_get_parent(cn);
>
> Doesn't this need to do an of_node_put()?
>
>> + if (!cn)
>> + pr_err("missing parent node for CPU %d\n", cpu);
>> + common_rate = of_get_property(cn, "clock-frequency",
&common_rate_len);
>
> And here too?
I have sent v2 in the meanwhile where I have refactored this part;
please review:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221221154213.24382-1-stefan.wiehler@nokia.com/
Kind regards,
Stefan Wiehler
Powered by blists - more mailing lists