linux-kernel - Re: [PATCH v5 4/4] media: platform: dwc: Add DW MIPI DPHY Rx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Dec 2022 02:23:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Eugen Hristev <eugen.hristev@...rochip.com>,
        linux-media@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
        luis.oliveira@...opsys.com,
        Eugen Hristev <eugen.hristev@...rochip.com>
Subject: Re: [PATCH v5 4/4] media: platform: dwc: Add DW MIPI DPHY Rx driver

Hi Eugen,

I love your patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on robh/for-next linus/master sailus-media-tree/streams v6.1 next-20221216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Eugen-Hristev/media-dwc-add-csi2host-driver/20221216-224024
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20221216143717.1002015-5-eugen.hristev%40microchip.com
patch subject: [PATCH v5 4/4] media: platform: dwc: Add DW MIPI DPHY Rx driver
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/35c9955340fd6d88770ab7d142b7a1d2b5b0d156
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Eugen-Hristev/media-dwc-add-csi2host-driver/20221216-224024
        git checkout 35c9955340fd6d88770ab7d142b7a1d2b5b0d156
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/media/platform/dwc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/media/platform/dwc/dw-csi-plat.c: In function 'dw_csi_probe':
   drivers/media/platform/dwc/dw-csi-plat.c:541:9: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
     541 |         else
         |         ^~~~
   drivers/media/platform/dwc/dw-csi-plat.c:544:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
     544 |                 goto end;
         |                 ^~~~
   In file included from drivers/media/platform/dwc/dw-csi-plat.c:11:
   At top level:
>> include/media/dwc/dw-csi-data.h:23:33: warning: 'csis' defined but not used [-Wunused-const-variable=]
      23 | static const struct pdata_names csis[] = {
         |                                 ^~~~


vim +/csis +23 include/media/dwc/dw-csi-data.h

4724a2dd0be3d5 Luis Oliveira 2022-12-16  22  
4724a2dd0be3d5 Luis Oliveira 2022-12-16 @23  static const struct pdata_names csis[] = {

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (292147 bytes)