linux-kernel - Re: [PATCH v5 3/4] media: platform: dwc: Add MIPI CSI-2 controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Dec 2022 03:24:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     Eugen Hristev <eugen.hristev@...rochip.com>,
        linux-media@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
        luis.oliveira@...opsys.com,
        Eugen Hristev <eugen.hristev@...rochip.com>,
        Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v5 3/4] media: platform: dwc: Add MIPI CSI-2 controller
 driver

Hi Eugen,

I love your patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on robh/for-next linus/master sailus-media-tree/streams v6.1 next-20221216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Eugen-Hristev/media-dwc-add-csi2host-driver/20221216-224024
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20221216143717.1002015-4-eugen.hristev%40microchip.com
patch subject: [PATCH v5 3/4] media: platform: dwc: Add MIPI CSI-2 controller driver
config: sh-allmodconfig
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/4724a2dd0be3d56efe12a8e617404c2880dd3c85
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Eugen-Hristev/media-dwc-add-csi2host-driver/20221216-224024
        git checkout 4724a2dd0be3d56efe12a8e617404c2880dd3c85
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/media/platform/dwc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/media/platform/dwc/dw-mipi-csi.c:61:6: warning: no previous prototype for 'dw_mipi_csi_write_part' [-Wmissing-prototypes]
      61 | void dw_mipi_csi_write_part(struct dw_csi *dev, u32 address, u32 data,
         |      ^~~~~~~~~~~~~~~~~~~~~~


vim +/dw_mipi_csi_write_part +61 drivers/media/platform/dwc/dw-mipi-csi.c

    56	
    57	#define dw_print(VAR) \
    58		dev_info(csi_dev->dev, "%s: 0x%x: %X\n", "#VAR#",\
    59		VAR, dw_mipi_csi_read(csi_dev, VAR))
    60	
  > 61	void dw_mipi_csi_write_part(struct dw_csi *dev, u32 address, u32 data,
    62				    u8 shift, u8 width)
    63	{
    64		u32 mask = (1 << width) - 1;
    65		u32 temp = dw_mipi_csi_read(dev, address);
    66	
    67		temp &= ~(mask << shift);
    68		temp |= (data & mask) << shift;
    69		dw_mipi_csi_write(dev, address, temp);
    70	}
    71	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (244389 bytes)