linux-kernel - Re: [PATCH v7 1/5] module.h: MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Dec 2022 12:50:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Allen Webb <allenwebb@...gle.com>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Luis Chamberlain <mcgrof@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Allen Webb <allenwebb@...gle.com>
Subject: Re: [PATCH v7 1/5] module.h: MODULE_DEVICE_TABLE for built-in modules

Hi Allen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on masahiroy-kbuild/fixes]
[also build test ERROR on mcgrof/modules-next westeri-thunderbolt/next linus/master v6.1 next-20221216]
[cannot apply to masahiroy-kbuild/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Allen-Webb/module-h-MODULE_DEVICE_TABLE-for-built-in-modules/20221217-071949
base:   https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git fixes
patch link:    https://lore.kernel.org/r/20221216221703.294683-2-allenwebb%40google.com
patch subject: [PATCH v7 1/5] module.h: MODULE_DEVICE_TABLE for built-in modules
config: alpha-allyesconfig
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/403b6f73d008681a1db43482df4038dd670f1bd4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Allen-Webb/module-h-MODULE_DEVICE_TABLE-for-built-in-modules/20221217-071949
        git checkout 403b6f73d008681a1db43482df4038dd670f1bd4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/cpumask.h:10,
                    from include/linux/mm_types_task.h:14,
                    from include/linux/mm_types.h:5,
                    from include/linux/buildid.h:5,
                    from include/linux/module.h:14,
                    from drivers/scsi/BusLogic.c:25:
>> include/linux/module.h:251:21: error: '__mod_pci__blogic_pci_tbl__kmod_BusLogic_device_table' aliased to undefined symbol 'blogic_pci_tbl'
     251 |         CONCATENATE(__mod_##type##__##name##__,                         \
         |                     ^~~~~~
   include/linux/kernel.h:491:24: note: in definition of macro '__CONCAT'
     491 | #define __CONCAT(a, b) a ## b
         |                        ^
   include/linux/module.h:250:14: note: in expansion of macro 'CONCATENATE'
     250 | extern void *CONCATENATE(                                               \
         |              ^~~~~~~~~~~
   include/linux/kernel.h:492:27: note: in expansion of macro '__CONCAT'
     492 | #define CONCATENATE(a, b) __CONCAT(a, b)
         |                           ^~~~~~~~
   include/linux/module.h:251:9: note: in expansion of macro 'CONCATENATE'
     251 |         CONCATENATE(__mod_##type##__##name##__,                         \
         |         ^~~~~~~~~~~
   drivers/scsi/BusLogic.c:3735:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
    3735 | MODULE_DEVICE_TABLE(pci, blogic_pci_tbl);
         | ^~~~~~~~~~~~~~~~~~~


vim +251 include/linux/module.h

   239	
   240	#ifdef MODULE
   241	/* Creates an alias so file2alias.c can find device table. */
   242	#define MODULE_DEVICE_TABLE(type, name)					\
   243	extern typeof(name) __mod_##type##__##name##_device_table		\
   244	  __attribute__ ((unused, alias(__stringify(name))))
   245	#else  /* !MODULE */
   246	/* The names may not be unique for built-in modules, so include the module name
   247	 * to guarantee uniqueness.
   248	 */
   249	#define MODULE_DEVICE_TABLE(type, name)					\
   250	extern void *CONCATENATE(						\
 > 251		CONCATENATE(__mod_##type##__##name##__,				\
   252			__KBUILD_MODNAME),					\
   253		_device_table)							\
   254		__attribute__ ((unused, alias(__stringify(name))))
   255	#endif
   256	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (314463 bytes)