linux-kernel - Re: [PATCH] f2fs: merge f2fs_show_injection_info() into time_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 17 Dec 2022 12:51:51 +0800
From:   Yangtao Li <frank.li@...o.com>
To:     jaegeuk@...nel.org, chao@...nel.org
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: merge f2fs_show_injection_info() into time_to_inject()

Hi Chao,

> Yeah, but it depends on compile option, right? If user use -O0 or -fno-inline option, inline function will not be expanded...

This is not a problem, we just need to mark it as __always_inline.

static __always_inline bool __time_to_inject(struct f2fs_sb_info *sbi, int type,
                                    const char *func_name)

> How about using deterministic implementation?

This way works, or do you have a better suggestion. After marking the function as __always_inline,
there will be no problem you mentioned.

Thx,
Yangtao