linux-kernel - Re: [PATCH] spi: dw_bt1: fix MUX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221218142231.qhczawk2zhpgh6dl@mobilestation>
Date:   Sun, 18 Dec 2022 17:22:31 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Mark Brown <broonie@...nel.org>,
        Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Ramil Zaripov <Ramil.Zaripov@...kalelectronics.ru>,
        Arnd Bergmann <arnd@...db.de>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: dw_bt1: fix MUX_MMIO dependencies

Hi Arnd

On Thu, Dec 15, 2022 at 05:52:34PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Selecting a symbol with additional dependencies requires
> adding the same dependency here:
> 
> WARNING: unmet direct dependencies detected for MUX_MMIO
>   Depends on [n]: MULTIPLEXER [=y] && OF [=n]
>   Selected by [y]:
>   - SPI_DW_BT1 [=y] && SPI [=y] && SPI_MASTER [=y] && SPI_DESIGNWARE [=y] && (MIPS_BAIKAL_T1 || COMPILE_TEST [=y])
> 
> Alternatively, we could drop this 'select' and require users to manually
> put it into their .config as we do for other drivers.

Thanks for the patch. Seeing the driver is only implicitly dependent
from the mux-mmio driver (via the device described in the device tree
blob) I'd suggest to either drop the MUX_MMIO config reverse
dependency or convert it to the weak one - 'imply' (if it will solve
the problem).

-Serge(y)

> 
> Fixes: 7218838109fe ("spi: dw-bt1: Fix undefined devm_mux_control_get symbol")
> Fixes: abf00907538e ("spi: dw: Add Baikal-T1 SPI Controller glue driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/spi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 3b1c0878bb85..1884e4083088 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -294,6 +294,7 @@ config SPI_DW_MMIO
>  config SPI_DW_BT1
>  	tristate "Baikal-T1 SPI driver for DW SPI core"
>  	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
> +	depends on OF
>  	select MULTIPLEXER
>  	select MUX_MMIO
>  	help
> -- 
> 2.35.1
>