linux-kernel - Re: [PATCH] nsfs: add compat ioctl handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y5+FOfgNHAnRkE5q@ZenIV>
Date:   Sun, 18 Dec 2022 21:25:13 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Serge Hallyn <serge@...lyn.com>, Andrey Vagin <avagin@...nvz.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Karel Zak <kzak@...hat.com>
Subject: Re: [PATCH] nsfs: add compat ioctl handler

On Sun, Dec 18, 2022 at 09:07:25PM +0000, Thomas Weißschuh wrote:
> As all parameters and return values of the ioctls have the same
> representation on both 32bit and 64bit we can reuse the normal ioctl
> handler for the compat handler.
> 
> All nsfs ioctls return a plain "int" filedescriptor which is a signed
> 4-byte integer type on both 32bit and 64bit.
> The only parameter taken is by NS_GET_OWNER_UID and is a pointer to a
> "uid_t" which is a 4-byte unsigned integer type on both 32bit and 64bit.
> 
> Fixes: 6786741dbf99 ("nsfs: add ioctl to get an owning user namespace for ns file descriptor")
> Reported-By: Karel Zak <kzak@...hat.com>
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

NAK.  This is broken on s390; use compat_ptr_ioctl instead.