[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y6APwfb9v2t3xUhv@MiWiFi-R3L-srv>
Date: Mon, 19 Dec 2022 15:16:17 +0800
From: Baoquan He <bhe@...hat.com>
To: Lorenzo Stoakes <lstoakes@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, urezki@...il.com,
stephen.s.brennan@...cle.com, willy@...radead.org,
akpm@...ux-foundation.org, hch@...radead.org
Subject: Re: [PATCH v2 5/7] mm/vmalloc: skip the uninitilized vmalloc areas
On 12/17/22 at 12:07pm, Lorenzo Stoakes wrote:
> On Sat, Dec 17, 2022 at 09:54:33AM +0800, Baoquan He wrote:
> > @@ -3617,6 +3617,11 @@ long vread(char *buf, char *addr, unsigned long count)
> > if (!vm && !flags)
> > continue;
> >
> > + if (vm->flags & VM_UNINITIALIZED)
> > + continue;
>
> This comes immediately after asserting that vm _might be null_. This surely must become:-
>
> if (vm && vm->flags & VM_UNINITIALIZED)
> continue;
You are right, will fix it in v3. Thanks for careful reivewing.
Powered by blists - more mailing lists