linux-kernel - Re: [PATCH v2 5/7] mm/vmalloc: skip the uninitilized vmalloc areas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y52w/w3IqJ0SCI6I@lucifer>
Date:   Sat, 17 Dec 2022 12:07:27 +0000
From:   Lorenzo Stoakes <lstoakes@...il.com>
To:     Baoquan He <bhe@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org, urezki@...il.com,
        stephen.s.brennan@...cle.com, willy@...radead.org,
        akpm@...ux-foundation.org, hch@...radead.org
Subject: Re: [PATCH v2 5/7] mm/vmalloc: skip the uninitilized vmalloc areas

On Sat, Dec 17, 2022 at 09:54:33AM +0800, Baoquan He wrote:
> @@ -3617,6 +3617,11 @@ long vread(char *buf, char *addr, unsigned long count)
>  		if (!vm && !flags)
>  			continue;
>
> +		if (vm->flags & VM_UNINITIALIZED)
> +			continue;

This comes immediately after asserting that vm _might be null_. This surely must become:-

if (vm && vm->flags & VM_UNINITIALIZED)
        continue;