[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f4f9c2cdb60e09b1fc3c07a59b3d02a031a27a32.camel@mediatek.com>
Date: Tue, 20 Dec 2022 12:49:50 +0000
From: Allen-KH Cheng (程冠勳)
<Allen-KH.Cheng@...iatek.com>
To: "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"ikjn@...omium.org" <ikjn@...omium.org>,
"krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
"sboyd@...nel.org" <sboyd@...nel.org>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
Chun-Jie Chen (陳浚桀)
<Chun-Jie.Chen@...iatek.com>
CC: "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
"wenst@...omium.org" <wenst@...omium.org>,
"angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 3/4] dt-bindings: arm: mediatek: Add missing power-domains
property
Hi Krzysztof,
Thanks for the reminder.
On Fri, 2022-12-16 at 11:58 +0100, Krzysztof Kozlowski wrote:
> On 15/12/2022 13:00, Allen-KH Cheng wrote:
> > The "mediatek,mt8192-scp_adsp" binding requires a power domain to
> > be
> > specified.
> >
> > Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document
> > bindings of MT8192 clock")
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
> > ---
> > .../arm/mediatek/mediatek,mt8192-clock.yaml | 17
> > +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-
> > clock.yaml
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-
> > clock.yaml
> > index b57cc2e69efb..cbedef114103 100644
> > ---
> > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-
> > clock.yaml
> > +++
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-
> > clock.yaml
> > @@ -40,6 +40,9 @@ properties:
> > reg:
> > maxItems: 1
> >
> > + power-domains:
> > + maxItems: 1
> > +
> > '#clock-cells':
> > const: 1
> >
> > @@ -49,11 +52,25 @@ required:
> >
> > additionalProperties: false
> >
> > +allOf:
>
> allOf goes just before additionalProperties.
>
ok, I will fix this.
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - mediatek,mt8192-scp_adsp
>
> For the future: please don't use underscores in compatibles.
>
Noted!
Thanks,
Allen
> > + then:
> > + required:
> > + - power-domains
> > +
> > examples:
> > - |
> > + #include <dt-bindings/power/mt8192-power.h>
> > +
> > scp_adsp: clock-controller@...20000 {
> > compatible = "mediatek,mt8192-scp_adsp";
> > reg = <0x10720000 0x1000>;
> > + power-domains = <&spm MT8192_POWER_DOMAIN_ADSP>;
> > #clock-cells = <1>;
> > };
> >
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists