[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221220125349.45091-1-yangxingui@huawei.com>
Date: Tue, 20 Dec 2022 12:53:49 +0000
From: Xingui Yang <yangxingui@...wei.com>
To: <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
<john.g.garry@...cle.com>
CC: <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linuxarm@...wei.com>, <yangxingui@...wei.com>,
<prime.zeng@...ilicon.com>, <kangfenglong@...wei.com>
Subject: [PATCH] scsi: libsas: Grab the host lock in sas_ata_device_link_abort()
Grab the host lock in sas_ata_device_link_abort() before calling
ata_link_abort(), as the comment in ata_link_abort() mentions.
Signed-off-by: Xingui Yang <yangxingui@...wei.com>
---
drivers/scsi/libsas/sas_ata.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index f7439bf9cdc6..4f2017b21e6d 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -889,7 +889,9 @@ void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)
{
struct ata_port *ap = device->sata_dev.ap;
struct ata_link *link = &ap->link;
+ unsigned long flags;
+ spin_lock_irqsave(ap->lock, flags);
device->sata_dev.fis[2] = ATA_ERR | ATA_DRDY; /* tf status */
device->sata_dev.fis[3] = ATA_ABORTED; /* tf error */
@@ -897,6 +899,7 @@ void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)
if (force_reset)
link->eh_info.action |= ATA_EH_RESET;
ata_link_abort(link);
+ spin_unlock_irqrestore(ap->lock, flags);
}
EXPORT_SYMBOL_GPL(sas_ata_device_link_abort);
--
2.17.1
Powered by blists - more mailing lists