[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4ec9dbed-1758-d6b4-dc1d-ac42e8c22731@oracle.com>
Date: Tue, 20 Dec 2022 14:59:14 +0000
From: John Garry <john.g.garry@...cle.com>
To: Xingui Yang <yangxingui@...wei.com>, jejb@...ux.ibm.com,
martin.petersen@...cle.com, niklas.cassel@....com,
damien.lemoal@...nsource.wdc.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
linuxarm@...wei.com, prime.zeng@...ilicon.com,
kangfenglong@...wei.com
Subject: Re: [PATCH] scsi: libsas: Grab the host lock in
sas_ata_device_link_abort()
On 20/12/2022 12:53, Xingui Yang wrote:
> Grab the host lock in sas_ata_device_link_abort() before calling
This is should be the ata port lock, right? I know that the ata comments
say differently.
> ata_link_abort(), as the comment in ata_link_abort() mentions.
>
Can you please add a fixes tag?
> Signed-off-by: Xingui Yang <yangxingui@...wei.com>
Reviewed-by: John Garry <john.g.garry@...cle.com>
> ---
> drivers/scsi/libsas/sas_ata.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index f7439bf9cdc6..4f2017b21e6d 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -889,7 +889,9 @@ void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)
> {
> struct ata_port *ap = device->sata_dev.ap;
> struct ata_link *link = &ap->link;
> + unsigned long flags;
>
> + spin_lock_irqsave(ap->lock, flags);
> device->sata_dev.fis[2] = ATA_ERR | ATA_DRDY; /* tf status */
> device->sata_dev.fis[3] = ATA_ABORTED; /* tf error */
>
> @@ -897,6 +899,7 @@ void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)
> if (force_reset)
> link->eh_info.action |= ATA_EH_RESET;
> ata_link_abort(link);
> + spin_unlock_irqrestore(ap->lock, flags);
> }
> EXPORT_SYMBOL_GPL(sas_ata_device_link_abort);
>
Powered by blists - more mailing lists