linux-kernel - Re: [PATCH v9 01/10] imx: Fix typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Dec 2022 15:32:15 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Allen Webb <allenwebb@...gle.com>
Cc:     "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>, stable@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v9 01/10] imx: Fix typo

On Tue, Dec 20, 2022 at 08:26:06AM -0600, Allen Webb wrote:
> On Mon, Dec 19, 2022 at 3:23 PM Luis Chamberlain <mcgrof@...nel.org> wrote:
> >
> > On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote:
> > > A one character difference in the name supplied to MODULE_DEVICE_TABLE
> > > breaks a future patch set, so fix the typo.
> >
> > What behaviour is broken here for older kernels? What would not work
> > that makes this patch worthy of consideration for stable? The commit
> > log should be clear on that.
> >
> > In the future, it may be useful for you to wait at least 1 week or so
> > before sending a new series becuase just a couple of days is not enough
> > if you are getting feedback.
> >
> > So before sending a v10, please give it at least a few days or a week.
> >
> >   Luis
> 
> On Tue, Dec 20, 2022 at 12:42 AM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote:
> > > A one character difference in the name supplied to MODULE_DEVICE_TABLE
> > > breaks a future patch set, so fix the typo.
> >
> > Breaking a future change is not worth a stable backport, right?  Doesn't
> > this fix a real issue now?  If so, please explain that.
> >
> > thanks,
> >
> > greg k-h
> 
> I will update the commit message to say that it breaks compilation
> when building imx8mp-blk-ctrl as a module (and so forth for the other
> similar patches).

Can that code be built as a module?  Same for the other changes...