linux-kernel - Re: [PATCH 2/2] mm: vmalloc: Replace BUG_ON() by WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6IFZozJxCkMTorA@lucifer>
Date:   Tue, 20 Dec 2022 18:56:38 +0000
From:   Lorenzo Stoakes <lstoakes@...il.com>
To:     "Uladzislau Rezki (Sony)" <urezki@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>, Baoquan He <bhe@...hat.com>,
        Christoph Hellwig <hch@...radead.org>,
        Matthew Wilcox <willy@...radead.org>,
        Nicholas Piggin <npiggin@...il.com>,
        Oleksiy Avramchenko <oleksiy.avramchenko@...y.com>
Subject: Re: [PATCH 2/2] mm: vmalloc: Replace BUG_ON() by WARN_ON_ONCE()

On Tue, Dec 20, 2022 at 06:53:18PM +0000, Lorenzo Stoakes wrote:
[snip
> Absolutely in favour of this in principle (BUG_ON() is something we should
> resort to in only the direst of circumstances), one small nit - perhaps it'd be
> neater to simply make this a guard clause? E.g.:-
>
> 	if (!WARN_ON_ONCE(!va))
> 		return;
>
> 	...

Made a mistake here, meant to say

 	if (WARN_ON_ONCE(!va))
 		return;

Of course :)

Apologies, only just noticed you are sending a v2, perhaps something to consider
for it? But will hold off further review until you send it! :)