linux-kernel - Re: [PATCH] input: raspberrypi-ts: Fix refcount leak in rpi_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y6IFHzJOM4qDyoWk@google.com>
Date:   Tue, 20 Dec 2022 10:55:27 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Rob Herring <robh@...nel.org>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Eric Anholt <eric@...olt.net>, linux-input@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: raspberrypi-ts: Fix refcount leak in rpi_ts_probe

On Tue, Dec 20, 2022 at 03:52:43PM +0400, Miaoqian Lin wrote:
> rpi_firmware_get() take reference, we need to release it in error paths
> as well. Add missing rpi_firmware_put() in the error handling to fix it.

Hmm, it used not to take a reference, but now it does... OK.

But I see there is devm_rpi_firmware_get() variant, we should be using
it instead of mixing up manual and devm-controller resources to ensure
proper release order.

Thanks.

-- 
Dmitry